Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[msl-out] Implement bounds checks for ImageLoad and ImageStore #1730

Merged
merged 1 commit into from
Feb 21, 2022
Merged

[msl-out] Implement bounds checks for ImageLoad and ImageStore #1730

merged 1 commit into from
Feb 21, 2022

Conversation

jimblandy
Copy link
Member

@jimblandy jimblandy commented Feb 16, 2022 •
edited
Loading

Posted early for silly reasons. ImageStore coming tomorrow. Comments welcome, of course.

kvark
kvark approved these changes Feb 17, 2022
View reviewed changes
Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

src/back/msl/writer.rs Outdated Show resolved Hide resolved
src/valid/expression.rs Outdated Show resolved Hide resolved
@jimblandy
Copy link
Member Author

just a rebase, comments not yet addressed

@kvark kvark mentioned this pull request Feb 18, 2022
Merged
@jimblandy jimblandy force-pushed the msl-texture-bounds branch 3 times, most recently from c4e4310 to 89d560f Compare February 20, 2022 07:33
@jimblandy jimblandy marked this pull request as ready for review February 20, 2022 07:33
@jimblandy jimblandy mentioned this pull request Feb 20, 2022
Merged
@jimblandy
Copy link
Member Author

I addressed the metal::uint namespace issue in a separate PR, #1740.

@jimblandy jimblandy force-pushed the msl-texture-bounds branch 2 times, most recently from f6ef7ee to 61703dc Compare February 21, 2022 22:57
@jimblandy
Copy link
Member Author

Okay, I've looked over all the output one last time, added some minor cleanups, and rebased on master.

@jimblandy jimblandy merged commit 679087b into gfx-rs:master Feb 21, 2022
@jimblandy jimblandy deleted the msl-texture-bounds branch February 21, 2022 23:08
@jimblandy jimblandy mentioned this pull request Apr 30, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvark kvark kvark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimblandy @kvark